Fix todo retrieval ordering by position#7
Merged
AkshajSinghal merged 1 commit intoJun 2, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_all_todos()by the storedpositioncolumn instead of relying on SQLite row orderpositionCloses #5.
Validation
python -m pytest tests/test_database.py -k ordered_by_positionpython -m pytest tests/test_database.pypython -m trushell --helptrushell --helpNotes
python -m pyteston my local macOS environment still hits the pre-existingtests/test_sound.py::test_play_alarm_uses_quiet_subprocessplatform assumption (afplayvspaplay).python -m ruff check .currently fails on the repository's existingpyproject.tomltarget-version = ["py310"]entry, which Ruff 0.15.15 does not parse as valid TOML.